Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Ogre 13 #1791

Closed
wants to merge 6 commits into from
Closed

Compatibility with Ogre 13 #1791

wants to merge 6 commits into from

Conversation

simonschmeisser
Copy link
Contributor

@simonschmeisser simonschmeisser commented Apr 28, 2023 •
edited
Loading

This fixes compatibility with Ogre 13.6.4, the most recent release. It requires two special cmake flags when building Ogre:

-DOGRE_NODELESS_POSITIONING:BOOL=TRUE \
-DOGRE_GLSUPPORT_USE_EGL:BOOL=FALSE \

@simonschmeisser
Copy link
Contributor Author

Packages: https://launchpad.net/~s-schmeisser/+archive/ubuntu/ogre-13

@simonschmeisser simonschmeisser force-pushed the fix-glsl-ogre-13 branch 3 times, most recently from 08af2d3 to 121f3a3 Compare May 3, 2023 15:09
@simonschmeisser simonschmeisser marked this pull request as ready for review May 3, 2023 15:12
rhaschke
rhaschke approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this. Your changes look good.
It would be great to include Ogre 1.13 in the GHA tests here:

rviz/.github/workflows/ci.yaml

Line 17 in 93ac44b

ogre: ["1.9", "1.12"]

To this end, we would need to setup a .deb repository to install libogre-13.x-dev from, which is done here:

rviz/.github/workflows/ci.yaml

Line 27 in 93ac44b

AFTER_INSTALL_TARGET_DEPENDENCIES: apt install -qq -y libogre-${{ matrix.ogre }}-dev

However, your PPA doesn't provide a -dev package and it is targeted at Jammy only.
Could you please augment?

@simonschmeisser
Copy link
Contributor Author

I'll check what it takes to build it on Focal, sure.

What do you mean by "doesn't provide a -dev package"? https://launchpad.net/~s-schmeisser/+archive/ubuntu/ogre-13/+packages has libogre-13.6-dev

@simonschmeisser
Copy link
Contributor Author

Note that I failed in getting gazebo to work with Ogre 13 as they use insane amounts of private API which is no longer accessible (or partially removed) in Ogre 13.

@rhaschke
Copy link
Contributor

What do you mean by "doesn't provide a -dev package"? https://launchpad.net/~s-schmeisser/+archive/ubuntu/ogre-13/+packages has libogre-13.6-dev

You are right. I just have seen the top-level entries.

Note that I failed in getting gazebo to work with Ogre 13 as they use insane amounts of private API which is no longer accessible (or partially removed) in Ogre 13.

I just want to ensure that future changes won't break Ogre 13 compatibility again...

@rhaschke
Copy link
Contributor

rhaschke commented Feb 3, 2024

Merged in 9911c32.

@rhaschke rhaschke closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonschmeisser @rhaschke